Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code, rename share path #9843

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Remove unused code, rename share path #9843

merged 11 commits into from
Oct 24, 2023

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Oct 23, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear enabled auto-merge (squash) October 23, 2023 15:03
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

9.4% 9.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@AlexAndBear AlexAndBear merged commit 8bb19c4 into master Oct 24, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the application-menu-followup branch October 24, 2023 11:53
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear added a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Remove unused code, rename share path (#9843)
9965367 
* Remove unused code, rename share path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann left review comments

@grimmoc grimmoc grimmoc approved these changes

@fschade fschade fschade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexAndBear @kulmann @fschade @grimmoc